Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for SmallVec in conversion traits (#3440) #3507

Merged
merged 3 commits into from
Oct 15, 2023

Conversation

orhun
Copy link
Contributor

@orhun orhun commented Oct 11, 2023

closes #3440

@orhun orhun force-pushed the feat/support_smallvec_conversion branch 3 times, most recently from 9834626 to e5eda2b Compare October 11, 2023 12:34
@orhun orhun force-pushed the feat/support_smallvec_conversion branch from e5eda2b to dfeae47 Compare October 11, 2023 14:14
@davidhewitt
Copy link
Member

Thank you! FYI other maintainers this was built with my collaboration in the EuroRust impl room, so it's best if I don't review (but can be responsible for follow up tidying).

Copy link
Member

@mejrs mejrs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Please add an entry to the features table in lib.rs, like here

Cargo.toml Outdated
@@ -41,6 +41,7 @@ num-bigint = { version = "0.4", optional = true }
num-complex = { version = ">= 0.2, < 0.5", optional = true }
rust_decimal = { version = "1.0.0", default-features = false, optional = true }
serde = { version = "1.0", optional = true }
smallvec = { version = "1.11.1", optional = true }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this not use version 1.0?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you mean? "smallvec = 1.0"

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, in general we try to accept as broad ranges of optional dependency versions as possible so that we don't have to force users to use specific versions.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it, made the change in 87cbd38

@orhun
Copy link
Contributor Author

orhun commented Oct 13, 2023

Added in 31acf0d

Copy link
Member

@davidhewitt davidhewitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again @orhun and good to meet you at EuroRust - I think this looks good now, so I'll merge it 👍

@davidhewitt davidhewitt added this pull request to the merge queue Oct 15, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 15, 2023
@davidhewitt
Copy link
Member

CI failure looks caused by latest psutil release; I can try to fix separately later.

@davidhewitt davidhewitt added this pull request to the merge queue Oct 15, 2023
@orhun
Copy link
Contributor Author

orhun commented Oct 15, 2023

Thanks @davidhewitt, it was nice to meet you as well, wish to see you again in events/open source world!

Merged via the queue into PyO3:main with commit aa28cec Oct 15, 2023
31 of 32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for SmallVec in conversion traits
3 participants